Film lovers forum
Search
Users   Registration   Entrance
Today: 27.01.2026 - 02:12:03
Pages:  1  

Reaper tries to remove the plugins IPlugView, before closing VST3 context menus

MessageAuthor

Linux, Reaper 6.43 When closing the FX window while a VST3 context menu is open, the context menu should be closed first before trying to remove the plugin's IPlugView. This causes problems when using Reaper with VST bridging software (Yabridge). The above description came from Robbert (the developer of Yabridge), after investigating why Reaper froze when I attempted to close a plugin with context menus open.




Nimble

Newbie


Statistics:
Messages: 2,504
Registration: 11.22.2002
Awards:
💊👓⚽👑💘

02.03.20 - 22:49:39
Message # 1
RE: Reaper tries to remove the plugins IPlugView, before closing VST3 context menus

Maybe this is why the preset dropdown in surge synth remains open if you close the plugin?


-----------------------------------------------
M3 SEDAN CLUB #12 2011 M3 ZCP 2006 M3 CS (SOLD ) 1993 E34 M5 Euro-Spec (SOLD )

Gop-Dogg

Newbie


Statistics:
Messages: 89
Registration: 12.04.2002
Awards:
💘💪🎓💊👓

02.03.20 - 22:53:31
Message # 2
RE: Reaper tries to remove the plugins IPlugView, before closing VST3 context menus

For the record, what happens when you close an editor window while a context menu is open is that during the IRunLoop::onFDIsSet() call where the plugin calls IContextMenu::popup(), REAPER calls IPlugView::removed() and IPlugView::release() from a nested event loop. This means that the plugin's plugview will be deallocated while it is still in the middle of calling IContextMenu::popup() further down the call stack on the same GUI thread. This can lead to all kinds of fun UB.




Emre

Newbie


Statistics:
Messages: 587
Registration: 10.28.2003
Awards:
👓🎁💊👮⚽👑💪

02.03.20 - 23:00:56
Message # 3
RE: Reaper tries to remove the plugins IPlugView, before closing VST3 context menus

Thanks for adding the additional info, Robbert. I'm now experiencing this bug (or at least it seems similar from user perspective) without any bridging or 3rd party plugins involved. I couldn't be 100% sure if it's the exact same thing, so I've made a new bug report here:


-----------------------------------------------
Cosmos/Black 97 328is: -3.23LSD-shark injected -S50 cams -Carbonio CF intake-UUC Big Boy Clutch Stop-Bilstein PSS9-Stromung Exhaust

jefiddler

Newbie


Statistics:
Messages: 493
Registration: 01.28.2002
Awards:
👑💊⚽💘

02.03.20 - 23:07:22
Message # 4
RE: Reaper tries to remove the plugins IPlugView, before closing VST3 context menus

Yes, it does not have anything to do with bridging. Any plugin would suffer from the same problem (on Linux at least, don't know how this behavior is implemented on Windows), although with some it may not be apparent. The main issue is that objects are being destroyed while in the middle of interacting with that object. In theory this issue could be avoided on the plugin's side by creating another copy of the smart pointer for the lifetime of the event handler so it can't get dropped until the function returns, but that should not be necessary and no plugin would normally do that.




Greek535

Newbie


Statistics:
Messages: 14
Registration: 10.14.2003
Awards:
🎁🎓💘

02.03.20 - 23:17:17
Message # 5
RE: Reaper tries to remove the plugins IPlugView, before closing VST3 context menus

How are you closing the plugin window specifically?




Icecream ///Man

Newbie


Statistics:
Messages: 533
Registration: 12.20.2002
Awards:
👓💘👑💊

02.03.20 - 23:22:08
Message # 6
RE: Reaper tries to remove the plugins IPlugView, before closing VST3 context menus

OK thanks. It may be that this behavior is specific to this window manager. I think that Windows and Mac will close a currently open context menu before closing a window. We'll think about how we might be able to mitigate this on our side.




jayhudson

Newbie


Statistics:
Messages: 11,931
Registration: 05.15.2001
Awards:
💘⚽💊🎓👮

02.03.20 - 23:33:37
Message # 7
RE: Reaper tries to remove the plugins IPlugView, before closing VST3 context menus

Yeah I think for now we'll make swell-gdk ignore those clicks if a menu is open (instead just closing the menu) -- this is what macOS does anyway -- eventually we can have it defer the close action until after the menu has closed and normal execution has resumed.


-----------------------------------------------
No matter where you go, there you are...

RRSperry

Newbie


Statistics:
Messages: 12,418
Registration: 03.18.2002
Awards:
👑👮🎁⚽👓

02.03.20 - 23:39:26
Message # 8
RE: Reaper tries to remove the plugins IPlugView, before closing VST3 context menus
Pages:  1  

The administrator has prohibited guests from replying to messages! To register, follow the link: register


Participants

inside: SMF 2.3.5